Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning with char being either signed or unsigned in ArithTraits #60

Closed
crtrott opened this issue Aug 30, 2017 · 0 comments
Closed

Fix warning with char being either signed or unsigned in ArithTraits #60

crtrott opened this issue Aug 30, 2017 · 0 comments
Assignees
@crtrott
Labels
enhancement InDevelop

Comments

@crtrott
Copy link
Member

crtrott commented Aug 30, 2017

On Power char is unsigned, while otherwise it is mostly signed. This causes issues in the abs function giving a warning on comparing x>=0. I've got a fix in the works.
@crtrott crtrott self-assigned this Aug 30, 2017
crtrott added a commit that referenced this issue Aug 30, 2017
@crtrott
Fix issue #60
71e45fb 
Warning with char in ArithTraits abs function on Power
crtrott added a commit that referenced this issue Aug 30, 2017
@crtrott
Merge pull request #61 from kokkos/issue-60
01dad6d 
Fix issue #60 
Everybody seems gone, I just override the review and merge in since that should fix the last failure on the Jenkins jobs for tonight.
@mhoemmen mhoemmen mentioned this issue Sep 1, 2017
Closed
@crtrott crtrott closed this as completed Sep 12, 2017
@kokkos-devops-admin kokkos-devops-admin mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crtrott crtrott

Labels
enhancement InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crtrott