Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortableNumericCHASH can't align shared memory #587

Closed
crtrott opened this issue Jan 29, 2020 · 4 comments
Closed

PortableNumericCHASH can't align shared memory #587

crtrott opened this issue Jan 29, 2020 · 4 comments
Assignees
@ndellingwood
Labels
bug fixed-in-develop bug InDevelop

Comments

@crtrott
Copy link
Member

crtrott commented Jan 29, 2020

This makes the PR for Kokkos/KokkosKernels Integration fail right now.

https://testing.sandia.gov/cdash/testDetails.php?test=100331563&build=6287299

This fails here:
KokkosSparse_spgemm_impl_kkmem.hpp:204
@ndellingwood
Copy link
Contributor

@crtrott yes, that was added after dealing with the shmem alignment issues. the requested shmem from the handle probably needs to be adjusted.

@ndellingwood
Copy link
Contributor

Original issue #500

@ndellingwood
Copy link
Contributor

Have a better handle on this, issues are occurring when dealing ensemble-like types.

Reverting this changes from #500 to determine thread_memory during construction necessary to address issue. Will put in a PR to the release-candidate-3.0 branch once fixes are confirmed.

ndellingwood added a commit that referenced this issue Jan 30, 2020
@ndellingwood
spgemm: more shmem alignment related fixes
7dea4f9 
Address issue #587
Integration testing with Trilinos exposed issues with handling of
shmem alignment with ensemble types.

This PR:
1. reverts how thread_memory is computed during functor construction
2. removes throws within functors when shmem unaligned
3. adds warning message and throws prior to kernel launch for cases
   with inappropriate shmem sizes
4. guards shmem realignment with KOKKOS_ENABLE_COMPLEX_ALIGN
     this keeps behavior consistent with Trilinos, but will
     need to be further addressed
5. some formatting cleanup and comments added
@ndellingwood ndellingwood mentioned this issue Jan 30, 2020
Merged
ndellingwood added a commit that referenced this issue Jan 31, 2020
@ndellingwood
spgemm: more shmem alignment related fixes
c75d7cf 
Address issue #587
Integration testing with Trilinos exposed issues with handling of
shmem alignment with ensemble types.

This PR:
1. reverts how thread_memory is computed during functor construction
2. removes throws within functors when shmem unaligned
3. adds warning message and throws prior to kernel launch for cases
   with inappropriate shmem sizes
4. guards shmem realignment with KOKKOS_ENABLE_COMPLEX_ALIGN
     this keeps behavior consistent with Trilinos, but will
     need to be further addressed
5. some formatting cleanup and comments added
@ndellingwood ndellingwood mentioned this issue Jan 31, 2020
Merged
@ndellingwood
Copy link
Contributor

ndellingwood commented Jan 31, 2020 •
edited
Loading

Addressed by PRs #588 (release-candidate-3.0, merged) and #591 (develop)

@ndellingwood ndellingwood self-assigned this Jan 31, 2020
@crtrott crtrott closed this as completed Apr 14, 2020
@kokkos-devops-admin kokkos-devops-admin mentioned this issue Nov 11, 2021
Merged
@kokkos-devops-admin kokkos-devops-admin mentioned this issue Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
bug fixed-in-develop bug InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crtrott @ndellingwood