Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SuperLU as optional CMake TPL #545

Closed
jjwilke opened this issue Dec 17, 2019 · 3 comments
Closed

Add SuperLU as optional CMake TPL #545

jjwilke opened this issue Dec 17, 2019 · 3 comments
Milestone

Comments

@jjwilke
Copy link
Contributor

jjwilke commented Dec 17, 2019

Add the necessary CMake options to enable SuperLU. This is tricky....

  • SuperLU might be installed as static or shared library
  • If static, SuperLU might or might not contain BLAS symbols
  • If containing BLAS symbols, they might be from an external BLAS or they might be wrapper functions implemented directly in SuperLU

Not clear how much error checking and validation we want to engineer into the CMake. It's very easy to add a basic TPL that just finds libsuperlu and adds the include path. It will be very difficult to figure out exactly how SuperLU was installed and generate good diagnostic messages.

@jjwilke
Copy link
Contributor Author

jjwilke commented Dec 17, 2019

My recommendation is to just do a simple TPL find. We could potentially also add a try_compile that builds a simple test program. If the test program fails, rather than generating an exact diagonstic, we just list all the possible reasons it could have failed.

@jjwilke
Copy link
Contributor Author

jjwilke commented Dec 17, 2019

@ndellingwood

@ndellingwood
Copy link
Contributor

@jjwilke I like your recommendation; the need for SuperLU in this case is for a specialization of sptrsv but will not be important to the rest of kokkos-kernels.

jjwilke pushed a commit to jjwilke/kokkos-kernels that referenced this issue Dec 17, 2019
jjwilke pushed a commit to jjwilke/kokkos-kernels that referenced this issue Dec 18, 2019
jjwilke pushed a commit to jjwilke/kokkos-kernels that referenced this issue Feb 10, 2020
@jjwilke jjwilke added this to the 3.1 Release milestone Mar 10, 2020
@crtrott crtrott closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants