-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation error on rzansel #401
Comments
@jhux2 : Strange error. We have nightlies with Cuda 9.2 but not with Xlc. Do you have gcc in this environment for a sanity check ? |
@srajama1 I think so, I'll try and report back. |
Tried these modules:
Appears to be the same type of error:
|
@jhux2 : I see what is causing the problem. A constant in the second argument to Kokkos atomic_fetch_add gets interpreted as int. I am not sure why every other platform works fine and it fails here. We will put in a fix. |
@srajama1 Good eyes, thank you! (I just tried gcc 4.9.3, and the compile fails the same way.) I am happy to try a patch for you. |
Not as simple as I thought, I get unsigned types in and need to a fetch add with -1, can't match them both. Need some reworking and time. |
@jhu2 Shouldn't 'ARCH' be 'KOKKOS_ARCH'? |
@jhux2 : I think @jjellio has a good catch, may be that will explain why it is only happening in this machine. I am still working through the changes, need some time with @ndellingwood to confirm what I am thinking. |
@jjellio Thanks for the suggestion. I just tried an XL build using |
@srajama1 has a patch with a fix for this. |
the constant input to Kokkos atomc_fetch_add
Fix #401. Address failures when compiling with xlc on certain platform
@jhux2 : We have a fix in develop. You have a Trilinos patch. Do you want that patch to be applied to Trilinos develop or can this wait till next Kokkos update ? |
@srajama1 @ndellingwood Thank you for fixing this. No, this can wait until the next snapshot. |
@jhux2 : Thanks ! Closing this. |
Shouldn't have closed. Per @crtrott need to leave it open till next Trilinos update as the issue is there :) |
@srajama1 let's just mark as InDevelop for now, we will close when the next promotion completes (this helps monitor stuff when creating the CHANGELOG) |
I'm attempting to compile Trilinos on rzansel at LLNL. I'm using a recipe that has worked for @csiefer2 on LLNL's lassen. The compile is failing in Kokkos-Kernels with this error:
error
Here is my setup:
Some relevant "magic" environment variables are
@nmhamster @srajama1
The text was updated successfully, but these errors were encountered: