Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong signature for axpy blas functions #329

Closed
finkandreas opened this issue Oct 19, 2018 · 2 comments
Closed

Wrong signature for axpy blas functions #329

finkandreas opened this issue Oct 19, 2018 · 2 comments

Comments

@finkandreas
Copy link

In the file src/impl/tpls/KokkosBlas1_axpby_tpl_spec_decl.hpp the function axpy is declared as

extern "C" void daxpy_( const int* N, const double* alpha,
                                      const double* x, const int* x_inc,
                                      const double* y, const int* y_inc);

but it should be:

extern "C" void daxpy_( const int* N, const double* alpha,
                                      const double* x, const int* x_inc,
                                      double* y, const int* y_inc);

The second last argument is an output argument, so it shall not be const. This applies also to the other axpy functions.

mhoemmen added a commit that referenced this issue Oct 19, 2018
"y" argument in BLAS `{s,d,c,z}axpy_` is nonconst.
@mhoemmen mhoemmen mentioned this issue Oct 19, 2018
@mhoemmen
Copy link
Contributor

Fix in PR #329. btw @finkandreas GitHub lets you submit a PR with just a few clicks -- you can edit the file in the browser -- so please feel free to submit a fix for issues like this if you like :-)

ndellingwood added a commit that referenced this issue Oct 22, 2018
@ndellingwood
Copy link
Contributor

PR #329 with fix by @mhoemmen merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants