Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing unit tests with float - unit test error checking issue #322

Closed
11 tasks done
ndellingwood opened this issue Oct 9, 2018 · 4 comments
Closed
11 tasks done

Comments

@ndellingwood
Copy link
Contributor

ndellingwood commented Oct 9, 2018

This was found testing on White with the OpenMP backend, float scalar types, and using the module devpack/20180521/openmpi/3.1.0/gcc/7.2.0/cuda/9.2.88 with openblas swapped for netlib/3.8.0/gcc/7.2.0.

Following PR #320 to fix the compilation error reported in #316 when enabling floats as scalar types, the following tests need to be fixed for error checking:

  • abs_float
  • abs_mv_float
  • nrm2_squared_float
  • nrm2_squared_mv_float
  • reciprocal_float
  • reciprocal_mv_float
  • scal_mv_float
  • team_scal_mv_float
  • scal_float
  • team_scal_float
  • sparse_trsv_mv_kokkos_complex_float

@kyungjoo-kim helped with fixing the error checking on the first couple tests, hoping to pattern match for the rest.

@ndellingwood
Copy link
Contributor Author

Also seeing some linking errors if I only build with float types, rather than float,double, e.g.

Test_OpenMP_Graph_graph_color_d2.o: In function
`KokkosGraph::Impl::GraphColorD2_MatrixSquared<KokkosKernels::Experimental::KokkosKernelsHandle<int const, int, double, Kokkos::OpenMP, Kokkos::HostSpace, Kokkos::HostSpace>, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<0u> >, Kokkos::View<int*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<0u> >, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<0u> >, Kokkos::View<int*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<0u> > >::color_graph_d2_matrix_squared()':

/ascldap/users/ndellin/kokkos-kernels/testing/White-Cuda9.2-GCC7.3-float/install/include/KokkosSparse_spgemm_symbolic.hpp:183:
undefined reference to `KokkosSparse::Impl::SPGEMM_SYMBOLIC<KokkosKernels::Experimental::KokkosKernelsHandle<int const, int const, double const, Kokkos::OpenMP, Kokkos::HostSpace, Kokkos::HostSpace>, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, Kokkos::View<int*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, false, false>::spgemm_symbolic(KokkosKernels::Experimental::KokkosKernelsHandle<int const, int const, double const, Kokkos::OpenMP, Kokkos::HostSpace, Kokkos::HostSpace>*, int, int, int, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, bool, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, Kokkos::View<int const*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >, bool, Kokkos::View<int*, Kokkos::LayoutLeft, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace>, Kokkos::MemoryTraits<1u> >)'

@ndellingwood
Copy link
Contributor Author

Getting a PR ready for this, thanks to @kyungjoo-kim for help!

ndellingwood added a commit that referenced this issue Oct 12, 2018
Addresses failing unit test and linking error in issue #322, also -Werror
@ndellingwood
Copy link
Contributor Author

ndellingwood commented Oct 12, 2018

PR #325 issued with fixes for the above.

@ndellingwood
Copy link
Contributor Author

Cross-reference older issue #97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants