Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trilinos/KokkosKernels reports no ETI in almost any circumstance #29

Closed
csiefer2 opened this issue May 4, 2017 · 4 comments
Closed

Comments

@csiefer2
Copy link
Contributor

csiefer2 commented May 4, 2017

I looked through a few of the dashboard tests and they all report KokkosKernels as not ETI-ing anything.

e.g.:


Processing ETI support: KokkosKernels
-- KokkosKernels: Processing ETI / test support
-- Enabled Scalar types:       
-- Enabled LocalOrdinal types: 
-- Enabled Device types:       
-- Set of enabled types, before exclusions: 

Is this to be expected?

@mhoemmen
Copy link
Contributor

mhoemmen commented May 4, 2017

@csiefer2 I'm not quite sure, but when @crtrott finished redoing KokkosKernels' ETI a little while ago, he replaced use of TriBITS' ETI system with an offline script. It should tie into TriBITS' macros, though, so I'm not sure what's going on here. Have you noticed a large build time inflation?

@mhoemmen
Copy link
Contributor

mhoemmen commented May 4, 2017

I'm getting this:

=======================
KokkosKernels ETI Types
   Devices: <OpenMP,HostSpace>;<Serial,HostSpace>
   Scalars: double
=======================

as well as this:

Processing ETI support: KokkosKernels
-- KokkosKernels: Processing ETI / test support
-- Enabled Scalar types:
-- Enabled LocalOrdinal types:
-- Enabled Device types:
-- Set of enabled types, before exclusions:

Did you see something like the former? Perhaps we should relabel this issue "Make KokkosKernels ETI only print once, correctly" :)

@crtrott
Copy link
Member

crtrott commented May 21, 2017

KokkosKernels does not utilize the Tribits ETI system. So I am not sure why it does print that thing out. It should print its own ETI support stuff out though.

@mhoemmen
Copy link
Contributor

@crtrott KokkosKernels currently still opts into Trilinos' ETI system. It looks like we should take that out, since KK ignores all that stuff anyway and uses different CMake options to drive its instantiations.

@crtrott crtrott self-assigned this Sep 8, 2017
@crtrott crtrott closed this as completed Sep 8, 2017
mzuzek pushed a commit to NexGenAnalytics/kokkos-kernels that referenced this issue Nov 3, 2021
mzuzek pushed a commit to NexGenAnalytics/kokkos-kernels that referenced this issue Nov 3, 2021
mzuzek pushed a commit to NexGenAnalytics/kokkos-kernels that referenced this issue Nov 3, 2021
mzuzek pushed a commit to NexGenAnalytics/kokkos-kernels that referenced this issue Nov 3, 2021
mzuzek pushed a commit to NexGenAnalytics/kokkos-kernels that referenced this issue Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants