Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Werror gcc/4.8.4: unknown-pragmas #pragma omp simd with OpenMP build #180

Closed
ndellingwood opened this issue Mar 13, 2018 · 7 comments
Closed

-Werror gcc/4.8.4: unknown-pragmas #pragma omp simd with OpenMP build #180

ndellingwood opened this issue Mar 13, 2018 · 7 comments
Assignees
@brian-kelley @ndellingwood
Labels
bug InDevelop

Comments

@ndellingwood
Copy link
Contributor 

In file included from /home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_spec.hpp:51:0,
                 from /home/ndellin/kokkos-kernels/src/impl/generated_specializations_cpp/gemm/KokkosBlas3_gemm_eti_spec_inst_double_LayoutLeft_Serial_HostSpace.cpp:46:
/home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_impl.hpp:343:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
     #pragma omp simd
 ^
In file included from /home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_spec.hpp:51:0,
                 from /home/ndellin/kokkos-kernels/src/impl/generated_specializations_cpp/gemm/KokkosBlas3_gemm_eti_spec_inst_double_LayoutLeft_Serial_HBWSpace.cpp:46:
/home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_impl.hpp:343:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
     #pragma omp simd
 ^
In file included from /home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_spec.hpp:51:0,
                 from /home/ndellin/kokkos-kernels/src/impl/generated_specializations_cpp/gemm/KokkosBlas3_gemm_eti_spec_inst_double_LayoutRight_Serial_HBWSpace.cpp:46:
/home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_impl.hpp:343:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
     #pragma omp simd
 ^
In file included from /home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_spec.hpp:51:0,
                 from /home/ndellin/kokkos-kernels/src/impl/generated_specializations_cpp/gemm/KokkosBlas3_gemm_eti_spec_inst_double_LayoutRight_Serial_HostSpace.cpp:46:
/home/ndellin/kokkos-kernels/src/blas/impl/KokkosBlas3_gemm_impl.hpp:343:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
     #pragma omp simd
cc1plus: all warnings being treated as errors
@ndellingwood ndellingwood self-assigned this Mar 13, 2018
@ndellingwood ndellingwood mentioned this issue Mar 13, 2018
Merged
@ndellingwood
Copy link
Contributor Author

PR #181 issued with a fix.

@ndellingwood
Copy link
Contributor Author

ndellingwood commented Mar 13, 2018 •
edited
Loading

gcc/4.8.4 implements OpenMP version 3.1 which does not support pragma omp simd (at least nowhere to be found in reference here openmp3.1), hence the -Werror for unknown pragma.

Relevant to discussion in trilinos/Trilinos#2317.

@nmhamster
Copy link
Contributor

Can we if def those out?

@ndellingwood
Copy link
Contributor Author

@nmhamster yeah, I just put in PR #181 doing that

@brian-kelley
Copy link
Contributor

brian-kelley commented Apr 19, 2020 •
edited
Loading

I'm reopening this because while doing the full cm_test_all_sandia on kokkos-dev2, 4.8.4 gives this:

In file included from /ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/batched/KokkosBatched_Vector.hpp:166:0,
                 from /ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/batched/KokkosBatched_Trsm_Decl.hpp:8,
                 from /ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/blas/impl/KokkosBlas3_trsm_impl.hpp:57,
                 from /ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/blas/impl/KokkosBlas3_trsm_spec.hpp:53,
                 from /ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/Testing/TestAll_2020-04-17_14.29.10/gcc/4.8.4/OpenMP-release/src/impl/generated_specializations_cpp/trsm/Blas3_trsm_eti_DOUBLE_LAYOUTLEFT_EXECSPACE_OPENMP_MEMSPACE_HOSTSPACE.cpp:48:
/ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/batched/KokkosBatched_Vector_SIMD.hpp:49:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
 #pragma omp simd 
 ^
/ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/batched/KokkosBatched_Vector_SIMD.hpp:63:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
 #pragma omp simd 
 ^
/ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/batched/KokkosBatched_Vector_SIMD.hpp:77:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
 #pragma omp simd 
 ^
/ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/batched/KokkosBatched_Vector_SIMD.hpp:92:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
 #pragma omp simd 
 ^
/ascldap/users/bmkelle/StdSortWorkaround-fulltest-1587158944/kokkos-kernels/src/batched/KokkosBatched_Vector_SIMD.hpp:113:0: error: ignoring #pragma omp simd [-Werror=unknown-pragmas]
 #pragma omp simd 
 ^

etc.

@brian-kelley brian-kelley reopened this Apr 19, 2020
@brian-kelley brian-kelley self-assigned this Apr 19, 2020
brian-kelley added a commit to brian-kelley/kokkos-kernels that referenced this issue Apr 19, 2020
@brian-kelley
Generalized fix for kokkos#180
363563d
@brian-kelley
Copy link
Contributor

The new fix for this is in #698, but other things in the PR aren't ready for merging yet.

crtrott pushed a commit that referenced this issue Apr 30, 2020
@brian-kelley @crtrott
Generalized fix for #180
6fce750
@brian-kelley
Copy link
Contributor

Fixd again in 3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-kelley brian-kelley

@ndellingwood ndellingwood

Labels
bug InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brian-kelley @nmhamster @ndellingwood