Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document & check CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=ON in CUDA build #148

Closed
mhoemmen opened this issue Feb 9, 2018 · 5 comments
Closed

Document & check CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=ON in CUDA build #148

mhoemmen opened this issue Feb 9, 2018 · 5 comments
Assignees
@ndellingwood
Labels
enhancement InDevelop

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Feb 9, 2018

kokkos-kernels requires setting the CMake option CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=ON with CUDA builds through TriBITS. See e.g., trilinos/Trilinos#2221 and trilinos/Trilinos#2115. kokkos-kernels should document this requirement, and its CMake logic should raise an error at configure time if this option is not set.
@mhoemmen
Copy link
Contributor Author

mhoemmen commented Feb 9, 2018

@rrdrake @prwolfe This could pose issues for Sierra's CUDA builds, due to Sierra's use of the Bjam build system.

@bartlettroscoe
Copy link
Contributor

I think this issue is now resolved. See trilinos/Trilinos#2115.

@mhoemmen
Copy link
Contributor Author

@bartlettroscoe "Document" means "in kokkos-kernels' documentation." "Check" means "in the CMake logic, such that if users don't specify the flag, the configuration process stops."

ndellingwood added a commit to ndellingwood/kokkos-kernels that referenced this issue Feb 13, 2018
@ndellingwood
CMakeLists: check for CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS with Cuda
29ac7e7 
Address request in issue kokkos#148 to check for
CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=ON when Cuda is enabled. If it
is not on, error out at configuration.
@ndellingwood ndellingwood mentioned this issue Feb 13, 2018
Merged
@ndellingwood
Copy link
Contributor

@mhoemmen @srajama1 added PR #149 with updated CMakeLists.txt to check if CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS=ON is set when Cuda is enabled; if not a message with FATAL_ERROR occurs at configuration indicating this should have been set.

@mhoemmen
Copy link
Contributor Author

@ndellingwood I posted my review there; thanks!

ndellingwood added a commit to ndellingwood/kokkos-kernels that referenced this issue Feb 13, 2018
@ndellingwood
CMakeLists: if check added for kokkos#148 incomplete - updated
086ec01 
Fix if check and grammar, suggestions from @mhoemmen
ndellingwood added a commit to ndellingwood/kokkos-kernels that referenced this issue Mar 14, 2018
@ndellingwood
CMakeLists: Restrict response file check to complex+double+Cuda
73239c9 
Addresses issue kokkos#148. The check for
CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS enabled is only necessary when
complex+double+Cuda with ETI occurs.
ndellingwood added a commit to ndellingwood/kokkos-kernels that referenced this issue Mar 14, 2018
@ndellingwood
CMakeLists: Fix check for complex double
1a720ff 
Part of issue kokkos#148
ndellingwood added a commit to ndellingwood/kokkos-kernels that referenced this issue Mar 14, 2018
@ndellingwood
CMakeLists: Replace FATAL_ERROR with WARNING
2d7326d 
Changes to address issue kokkos#148
@ndellingwood ndellingwood mentioned this issue Apr 10, 2018
Closed
@ndellingwood ndellingwood mentioned this issue May 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndellingwood ndellingwood

Labels
enhancement InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mhoemmen @bartlettroscoe @ndellingwood