Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spmv for CrsMatrix, Kokkos::Serial, fOp = "C" has a bug #1048

Closed
uhetmaniuk opened this issue Jul 13, 2021 · 0 comments
Closed

spmv for CrsMatrix, Kokkos::Serial, fOp = "C" has a bug #1048

uhetmaniuk opened this issue Jul 13, 2021 · 0 comments
Assignees
@lucbv @uhetmaniuk
Labels
bug InDevelop

Comments

@uhetmaniuk
Copy link
Contributor

uhetmaniuk commented Jul 13, 2021 •
edited
Loading

Lines do not include the conjugation operation when it is requested.

In contrast, for the hermitian operation, the lines include the conjugation.
@uhetmaniuk uhetmaniuk added the bug label Jul 13, 2021
brian-kelley added a commit to brian-kelley/kokkos-kernels that referenced this issue Aug 18, 2021
@brian-kelley
Fix kokkos#1048: handle mode C correctly in serial/openmp
b985448 
- Testing: have IOUtils sparse matrix generator use getRandomBounds()
  and the Kokkos PRNG, so that complex values actually have nonzero
  imaginary component. Before, it was always 0, so mode N and C spmvs
  were equivalent and this was never caught by testing.
- Serial: in unrolled impl, conjugate A's values in mode C
- OpenMP: just don't use the special omp impl in mode C
  (this kernel is pretty much never called in practice anyway, see
  comment in code)
brian-kelley added a commit that referenced this issue Aug 25, 2021
@brian-kelley
Merge pull request #1084 from brian-kelley/Fix1048
55a5805 
Fix #1048: handle mode C spmv correctly in serial/openmp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucbv lucbv

@uhetmaniuk uhetmaniuk

Labels
bug InDevelop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brian-kelley @lucbv @uhetmaniuk