Skip to content

Commit

Permalink
ArithTraits: removing some unnecessary comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lucbv committed May 19, 2022
1 parent 4545cfb commit a80a38d
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/common/Kokkos_ArithTraits.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1138,7 +1138,7 @@ class ArithTraits<float> {
}
static KOKKOS_FORCEINLINE_FUNCTION mag_type eps() { return epsilon(); }
static KOKKOS_FORCEINLINE_FUNCTION mag_type sfmin() {
return Kokkos::Experimental::norm_min<val_type>::value; // ???
return Kokkos::Experimental::norm_min<val_type>::value;
}
static KOKKOS_FORCEINLINE_FUNCTION int base() {
return Kokkos::Experimental::radix<val_type>::value;
Expand All @@ -1156,15 +1156,14 @@ class ArithTraits<float> {
return Kokkos::Experimental::min_exponent<val_type>::value;
}
static KOKKOS_FORCEINLINE_FUNCTION mag_type rmin() {
return Kokkos::Experimental::norm_min<val_type>::value; // ??? // should be
// base^(emin-1)
return Kokkos::Experimental::norm_min<val_type>::value;
}
static KOKKOS_FORCEINLINE_FUNCTION int emax() {
return Kokkos::Experimental::max_exponent<val_type>::value;
}
static KOKKOS_FORCEINLINE_FUNCTION mag_type rmax() {
return Kokkos::Experimental::finite_max<
val_type>::value; // ??? // should be (base^emax)*(1-eps)
val_type>::value;
}
};

Expand Down

0 comments on commit a80a38d

Please sign in to comment.