Fix signed/unsigned comparison warnings (#2150)

This is only hit when spmv is called with integer scalars, which doesn't happen in our CI but does often in Tpetra.
kokkos · Mar 25, 2024 · 89598d8 · 89598d8
1 parent 0c49c21
commit 89598d8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sparse/impl/KokkosSparse_spmv_bsrmatrix_spec.hpp b/sparse/impl/KokkosSparse_spmv_bsrmatrix_spec.hpp
@@ -349,7 +349,7 @@ struct SPMV_MV_BSRMATRIX<ExecutionSpace, Handle, AMatrix, XVector, YVector,
                                 const YScalar &beta, const YVector &Y) {
     static_assert(std::is_integral_v<typename AMatrix::non_const_value_type>,
                   "This implementation is only for integer Scalar types.");
-    for (typename AMatrix::non_const_size_type j = 0; j < X.extent(1); ++j) {
+    for (size_t j = 0; j < X.extent(1); ++j) {
       const auto x_j = Kokkos::subview(X, Kokkos::ALL(), j);
       auto y_j       = Kokkos::subview(Y, Kokkos::ALL(), j);
       typedef SPMV_BSRMATRIX<ExecutionSpace, Handle, AMatrix, decltype(x_j),

diff --git a/sparse/impl/KokkosSparse_spmv_spec.hpp b/sparse/impl/KokkosSparse_spmv_spec.hpp
@@ -268,7 +268,7 @@ struct SPMV_MV<ExecutionSpace, Handle, AMatrix, XVector, YVector, true, false,
     static_assert(std::is_integral_v<typename AMatrix::non_const_value_type>,
                   "This implementation is only for integer Scalar types.");
     KokkosKernels::Experimental::Controls defaultControls;
-    for (typename AMatrix::non_const_size_type j = 0; j < x.extent(1); ++j) {
+    for (size_t j = 0; j < x.extent(1); ++j) {
       auto x_j = Kokkos::subview(x, Kokkos::ALL(), j);
       auto y_j = Kokkos::subview(y, Kokkos::ALL(), j);
       typedef SPMV<ExecutionSpace, Handle, AMatrix, decltype(x_j),