Skip to content

Commit

Permalink
Fix #1631
Browse files Browse the repository at this point in the history
Revert one line from #1620 which changed CrsMatrix::values_type (a 1D
view) to be default_layout instead of LayoutRight. This seemed totally
reasonable (the graph's rowptrs/entries already used default_layout),
but the change makes spmv give wrong answers with Sacado PCE or MPVector
as the scalar type.
  • Loading branch information
brian-kelley committed Dec 17, 2022
1 parent 4c06b6c commit 57e161d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sparse/src/KokkosSparse_CrsMatrix.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,8 @@ class CrsMatrix {
//! Nonconst version of the type of row offsets in the sparse matrix.
typedef typename row_map_type::non_const_value_type non_const_size_type;
//! Kokkos Array type of the entries (values) in the sparse matrix.
typedef Kokkos::View<value_type*, default_layout, device_type, MemoryTraits>
typedef Kokkos::View<value_type*, Kokkos::LayoutRight, device_type,
MemoryTraits>
values_type;
//! Const version of the type of the entries in the sparse matrix.
typedef typename values_type::const_value_type const_value_type;
Expand Down

0 comments on commit 57e161d

Please sign in to comment.