Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings after #369 merge #439

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Jul 17, 2023

#369 created two warnings:

  • title underline too short
  • printf is not referenced in any tables

I corrected them with this PR.
It's all part of the issue: #378
We want to keep our build free of errors and warnings!

@antoinemeyer5 antoinemeyer5 changed the title Fix warning after #369 merge Fix warnings after #369 merge Jul 17, 2023
@antoinemeyer5 antoinemeyer5 marked this pull request as ready for review July 17, 2023 09:03
@dalg24
Copy link
Member

dalg24 commented Jul 17, 2023

You say that the fact printf is not referenced anywhere causes a warning but this PR is only fixing the underline.
Did you mean to add a reference?

@antoinemeyer5
Copy link
Collaborator Author

antoinemeyer5 commented Jul 17, 2023

You say that the fact printf is not referenced anywhere causes a warning but this PR is only fixing the underline. Did you mean to add a reference?

I also moved the file @dalg24

image

From docs/source/API/core/ to docs/source/API/core/utilities/

And this resolved the second warning!

Sorry I wasn't clear

@antoinemeyer5 antoinemeyer5 self-assigned this Jul 17, 2023
@dalg24 dalg24 merged commit 0feb08c into kokkos:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants