Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#120: API-core-c_style_memory_management-free from md to rst #305

Merged
merged 5 commits into from
Mar 3, 2023
Merged

#120: API-core-c_style_memory_management-free from md to rst #305

merged 5 commits into from
Mar 3, 2023

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Feb 21, 2023 •
edited
Loading

THIS PR:

  • API/core/c_style_memory_management/free transition from .md to .rst
before (.md) after (.rst)
image image

@antoinemeyer5 antoinemeyer5 mentioned this pull request Feb 21, 2023
Closed
fnrizzi
fnrizzi requested changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as in #307

@antoinemeyer5 antoinemeyer5 requested a review from fnrizzi March 2, 2023 10:21
fnrizzi
fnrizzi requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow this #307

@antoinemeyer5 antoinemeyer5 requested a review from fnrizzi March 2, 2023 15:00
@fnrizzi fnrizzi merged commit 94151a6 into kokkos:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnrizzi fnrizzi fnrizzi approved these changes

@nmm0 nmm0 Awaiting requested review from nmm0

@ajpowelsnl ajpowelsnl Awaiting requested review from ajpowelsnl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinemeyer5 @fnrizzi