Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#120: API-core-builtinreducers-LOr from md to rst #279

Merged
merged 3 commits into from
Feb 1, 2023
Merged

#120: API-core-builtinreducers-LOr from md to rst #279

merged 3 commits into from
Feb 1, 2023

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Jan 26, 2023 •
edited
Loading

THIS PR:

  • API/core/builtinreducers/LOr transition from .md to .rst
  • uses cppkokkos
  • rebased on latest main
before (.md) after (.rst)
image image
image image

@antoinemeyer5 antoinemeyer5 mentioned this pull request Jan 26, 2023
Closed
nmm0
nmm0 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

fnrizzi
fnrizzi requested changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per our 1:1 discussion

@antoinemeyer5 antoinemeyer5 marked this pull request as draft February 1, 2023 12:10
@antoinemeyer5 antoinemeyer5 requested review from fnrizzi and nmm0 February 1, 2023 12:15
@antoinemeyer5 antoinemeyer5 marked this pull request as ready for review February 1, 2023 12:16
@fnrizzi fnrizzi merged commit 1edfce4 into kokkos:main Feb 1, 2023
@antoinemeyer5 antoinemeyer5 deleted the 120-API-core-builtinreducers-LOr branch June 14, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnrizzi fnrizzi fnrizzi approved these changes

@ajpowelsnl ajpowelsnl Awaiting requested review from ajpowelsnl

@nmm0 nmm0 Awaiting requested review from nmm0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoinemeyer5 @nmm0 @fnrizzi