Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#120: API-core-numerics-mathematical_functions from md to rst #266

Merged
merged 7 commits into from
Feb 6, 2023
Merged

#120: API-core-numerics-mathematical_functions from md to rst #266

merged 7 commits into from
Feb 6, 2023

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Jan 16, 2023 •
edited
Loading

THIS PR:

  • API/core/numerics/mathematical-functions transition from .md to .rst
  • uses cppkokkos
  • rebased on latest main
before (.md) after (.rst)
image image
image image
image image

@antoinemeyer5 antoinemeyer5 mentioned this pull request Jan 16, 2023
Closed
ajpowelsnl
ajpowelsnl requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Antoine - I've suggested a solution. Please let me know if it's not workable for the problems you're seeing.

docs/source/API/core/numerics/mathematical-functions.rst Show resolved Hide resolved
@antoinemeyer5 antoinemeyer5 mentioned this pull request Jan 19, 2023
Merged
@antoinemeyer5 antoinemeyer5 marked this pull request as ready for review January 26, 2023 10:14
@fnrizzi fnrizzi merged commit 1d19085 into kokkos:main Feb 6, 2023
@antoinemeyer5 antoinemeyer5 deleted the 120-core-numerics-mathematical_functions branch June 14, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpowelsnl ajpowelsnl ajpowelsnl approved these changes

@fnrizzi fnrizzi fnrizzi approved these changes

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoinemeyer5 @PhilMiller @fnrizzi @ajpowelsnl