Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#120: API-core-SpaceAccessibility from md to rst #249

Merged
merged 7 commits into from
Jan 24, 2023
Merged

#120: API-core-SpaceAccessibility from md to rst #249

merged 7 commits into from
Jan 24, 2023

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Jan 5, 2023 •
edited
Loading

THIS PR:

  • API/core/SpaceAccessibility transition from .md to .rst
before (.md) after (.rst) after 2 (.rst)
before_1 after_1
before_2 after_2 after2_2
before_3 after_3

@antoinemeyer5 antoinemeyer5 mentioned this pull request Jan 5, 2023
Closed
ajpowelsnl
ajpowelsnl approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page itself looks fine, however, the content is not understandable. Would it be possible to flag this page for (future) polishing after everything is converted to .rst? I separate the conversion activities from the polishing. Maybe you could put FIXME: CONTENT POLISHING at the top of such pages ?

@antoinemeyer5

This comment was marked as outdated.

Sign in to view
@PhilMiller
Copy link
Contributor

Please don't visibly mark pages unless they're fundamentally wrong in some way. Just open an issue for follow up here.

@antoinemeyer5
Copy link
Collaborator Author

antoinemeyer5 commented Jan 19, 2023 •
edited
Loading

Please don't visibly mark pages unless they're fundamentally wrong in some way. Just open an issue for follow up here.

Okay I do that (here: #269) and remove the message on the page.

I was also thinking that this was very odd. I misunderstood "Maybe you could put FIXME: CONTENT POLISHING at the top of such pages ?".

Sorry and thanks for your help!

@antoinemeyer5 antoinemeyer5 mentioned this pull request Jan 19, 2023
Closed
@ajpowelsnl
Copy link
Contributor

Please don't visibly mark pages unless they're fundamentally wrong in some way. Just open an issue for follow up here.

Okay I do that (here: #269) and remove the message on the page.

I was also thinking that this was very odd. I misunderstood "Maybe you could put FIXME: CONTENT POLISHING at the top of such pages ?".

Sorry and thanks for your help!

Sorry -- I should have specified "FIXME" as a comment, and not something that would be visible in the page. But I'm happy to go with Phil's suggestion.

ajpowelsnl
ajpowelsnl approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversion itself is fine. Content polishing can happen another day.

@fnrizzi fnrizzi merged commit 833aeb2 into kokkos:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpowelsnl ajpowelsnl ajpowelsnl approved these changes

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoinemeyer5 @PhilMiller @ajpowelsnl @fnrizzi