Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#120: API-core-policies-NestedPolicies from md to rst #242

Merged

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Dec 28, 2022

THIS PR:

  • API/core/policies/NestedPolicies transition from .md to .rst
  • uses cppkokkos
  • rebased on latest main
before (.md) after (.rst)
before_1 image
before_2 after_2
before_3 after_3

@fnrizzi
Copy link
Collaborator

fnrizzi commented Jan 2, 2023

the description of each function should be indented so that it shows as part of the function

@antoinemeyer5
Copy link
Collaborator Author

indentation corrected, screenshots are up to date ! @fnrizzi & @ajpowelsnl

Copy link
Collaborator

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per our 1:1 discussion

@antoinemeyer5 antoinemeyer5 requested a review from fnrizzi January 31, 2023 21:13
@fnrizzi fnrizzi merged commit 1ca692f into kokkos:main Feb 1, 2023
@antoinemeyer5 antoinemeyer5 deleted the 120-API-core-policies-NestedPolicies branch June 14, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants