Merge pull request #113 from cwpearson/enhancement/dont-extend-unmanaged

Don't uselessly extend lifetimes of unmanaged views
kokkos · Jul 12, 2024 · d34862d · d34862d
2 parents e6b32ad + 56d6149
commit d34862d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/KokkosComm_request.hpp b/src/KokkosComm_request.hpp
@@ -54,7 +54,10 @@ class Req {
   // keep a reference to this view around until wait() is called
   template <typename View>
   void keep_until_wait(const View &v) {
-    record_->until_waits_.push_back(std::make_shared<ViewHolder<View>>(v));
+    // unmanaged views don't own the underlying buffer, so no need to extend lifetime
+    if (v.use_count() != 0) {
+      record_->until_waits_.push_back(std::make_shared<ViewHolder<View>>(v));
+    }
   }
 
  private: