Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pnpm support #730

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Add pnpm support #730

merged 3 commits into from
Jun 25, 2022

Conversation

ConstasJ
Copy link
Contributor

No description provided.

@shigma
Copy link
Member

shigma commented Jun 24, 2022

This PR does not really add pnpm support.

@shigma shigma added the invalid 看起来不太对 label Jun 24, 2022
@ConstasJ
Copy link
Contributor Author

What I do is adding pnpm-workspace.yml to enable pnpm workspaces in this monorepo repository.I think after that this repo can use pnpm.
So why do you think that this PR do not really add pnpm support?

@shigma
Copy link
Member

shigma commented Jun 24, 2022

I think after that this repo can use pnpm.

It actually can not.

  1. Koishi does not and will not support the isolated linker so you need to configurate your .npmrc file.
  2. This PR does not help users of Koishi, only to provide incomplete support for official repository developers. However developers in the official repository should follow the prerequisites which includes using our recommended package managers. Introduction of pnpm means that more edge cases may continue to be introduced in the future, which the development team did not need and should not consider.

@ConstasJ
Copy link
Contributor Author

しかし、僕はまだpnpmを使用する方がyarnを使用するよりもはるかに良い選択だと思います。

@ConstasJ
Copy link
Contributor Author

koishiチームがこの問題を検討してくれることを願っています

@ilharp
Copy link
Member

ilharp commented Jun 24, 2022

  1. According to corepack practice one project can only choose one single PM to use.

  2. There have been many reports that Koishi cannot start using pnpm. See document.

@ilharp
Copy link
Member

ilharp commented Jun 24, 2022

I recommend locking PM for Koishi to avoid possible future problems:

  {
    "name": "@root/koishi",
    "private": true,
+   "packageManager": "yarn@1.22.19",
    "workspaces": [

@ConstasJ ConstasJ closed this Jun 24, 2022
@ConstasJ ConstasJ deleted the pnpm-support branch June 24, 2022 13:31
@ConstasJ ConstasJ restored the pnpm-support branch June 24, 2022 13:32
@ConstasJ ConstasJ reopened this Jun 25, 2022
@shigma shigma removed the invalid 看起来不太对 label Jun 25, 2022
@shigma shigma merged commit 99c720c into koishijs:master Jun 25, 2022
shigma pushed a commit that referenced this pull request Jun 25, 2022
Co-Authored-By: Il Harper <afanyiyu@hotmail.com>
@ConstasJ ConstasJ deleted the pnpm-support branch June 26, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants