Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contributing guide #707

Merged
merged 4 commits into from
Jun 10, 2022
Merged

chore: update contributing guide #707

merged 4 commits into from
Jun 10, 2022

Conversation

MaikoTan
Copy link
Member

@MaikoTan MaikoTan commented May 29, 2022

I think there are several issues in the previous guide, so I changed the following things:

  • Commonly the contributing guide is put into CONTRIBUTNIG.md not .github/contributing.md.
  • Change default branch from develop to master as develop branch is no longer using.
  • Use 我们 or 开发团队 to refer to our self.
  • Add a code of conduct guide from Contributor Covenant.

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #707 (3069b33) into master (6e3a66a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   90.16%   90.13%   -0.04%     
==========================================
  Files          69       69              
  Lines        8146     8147       +1     
  Branches     1382     1384       +2     
==========================================
- Hits         7345     7343       -2     
- Misses        801      804       +3     
Impacted Files Coverage Δ
plugins/frontend/console/src/http.ts 23.95% <0.00%> (-2.40%) ⬇️
plugins/mock/src/adapter.ts 100.00% <0.00%> (ø)
plugins/mock/src/webhook.ts 25.31% <0.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3a66a...3069b33. Read the comment docs.

@shigma
Copy link
Member

shigma commented Jun 9, 2022

Is there anything else that prevents this PR from being ready for review?

@MaikoTan
Copy link
Member Author

Is there anything else that prevents this PR from being ready for review?

Some sentences are not quite natural, but I think to give it a try is not bad.

@MaikoTan MaikoTan marked this pull request as ready for review June 10, 2022 06:34
@MaikoTan MaikoTan requested a review from shigma June 10, 2022 08:06
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@shigma shigma merged commit c7bc487 into master Jun 10, 2022
@shigma shigma deleted the renew-contribute-guide branch June 10, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants