Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add milestoned issue backlogging #674

Merged
merged 5 commits into from
May 16, 2022
Merged

CI: Add milestoned issue backlogging #674

merged 5 commits into from
May 16, 2022

Conversation

H4M5TER
Copy link
Member

@H4M5TER H4M5TER commented May 8, 2022

已经跑通了,配一下 secrets.BACKLOG_PAT

@H4M5TER H4M5TER force-pushed the ci/milestone-backlog branch from b54ac94 to 2111b9a Compare May 8, 2022 21:15
@H4M5TER H4M5TER changed the title Add milestoned issue backlogging CI: Add milestoned issue backlogging May 8, 2022
Copy link
Member

@shigma shigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改 ts 放 build 目录

@MaikoTan
Copy link
Member

MaikoTan commented May 9, 2022

加一行
if: ${{ github.repository == 'koishijs/koishi' }}

毕竟它在 fork 上运行毫无意义

@H4M5TER
Copy link
Member Author

H4M5TER commented May 9, 2022

加一行 if: ${{ github.repository == 'koishijs/koishi' }}

毕竟它在 fork 上运行毫无意义

fork 没有 milestone 和 issue 的话不会触发这个的吧,但是可以,因为我代码里硬编码 shigma 了

@H4M5TER
Copy link
Member Author

H4M5TER commented May 9, 2022

改 ts 放 build 目录

介绍一下 build 目录是怎么工作的,你希望 ci 在哪里拿到编译好的 backlog.js,以及我要怎么让它编译到那里去

@MaikoTan
Copy link
Member

MaikoTan commented May 9, 2022

改 ts 放 build 目录

介绍一下 build 目录是怎么工作的,你希望 ci 在哪里拿到编译好的 backlog.js,以及我要怎么让它编译到那里去

node -r ./build/register ./build/backlog.ts 可以直接運行 ts 文件(記得先 yarn install)

@H4M5TER
Copy link
Member Author

H4M5TER commented May 9, 2022

这是 CI 标准流程吗,需不需要指定一下要装的包(esbuild 和什么),如果全部都装的话,我就直接在 setup-node 里 cache: yarn 了,有一个问题是 install 的速度很大跟 ci 服务器有没有缓存有关系,(之前已经遇到但是忘记提了)导致如果短时间触发两次 action 的话,有可能第二个装完包跑完了第一个才开始跑,导致一点问题。(可能多装一点包还能拉平这个装包时间((

@MaikoTan
Copy link
Member

MaikoTan commented May 9, 2022

確實,最好加個 cache(

@H4M5TER
Copy link
Member Author

H4M5TER commented May 9, 2022

这个 cache 它是需要 lock 的,我们是否已经有一个给 ci 用的 lock 了?

@MaikoTan
Copy link
Member

MaikoTan commented May 9, 2022

直接設置讓 yarn 忽略 lock 吧,比如可以用 --no-lockfile ?

EDIT:啊,我理解錯了問題。他不是需要 lock,他只是需要一個文件讓他能夠 generate 出 hash,讓他能找到最匹配的版本。你直接用 package.json 也可以的。

@H4M5TER
Copy link
Member Author

H4M5TER commented May 15, 2022

拆出来开仓库测过了
(然后忘记这回事了

- name: Backlog
uses: H4M5TER/milestone-backlog@v1.0
with:
token: ${{ secrets.BACKLOG_PAT }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
token: ${{ secrets.BACKLOG_PAT }}
token: ${{ secrets.WORKFLOW_TOKEN }}

issues:
types:
- "milestoned"
- "demilestoned"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

引号删掉吧

@shigma shigma merged commit 2fc58aa into master May 16, 2022
@shigma shigma deleted the ci/milestone-backlog branch May 16, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants