-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(discord): improvements #212
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #212 +/- ##
===========================================
+ Coverage 92.34% 92.56% +0.22%
===========================================
Files 53 53
Lines 10638 10645 +7
Branches 2176 2251 +75
===========================================
+ Hits 9824 9854 +30
+ Misses 814 791 -23
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 5e18f32 into 4f80be4 - view on LGTM.com new alerts:
|
@@ -9,6 +9,18 @@ import { segment } from 'koishi-utils' | |||
import FormData from 'form-data' | |||
import FileType from 'file-type' | |||
|
|||
export class SenderError extends Error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
于是乎这个 1.0 时期就有的古董类被你们抄进了每一个 adapter……我已经开始考虑要不要直接从 koishi-core 导出了……当然不是这个 PR 该干的事情就是了,我随便吐槽而已。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
但我昨天加了个试了下发现没啥用,丢出来的还是axios又长又烂的exception,丢人
This pull request fixes 1 alert when merging c7ff481 into b429522 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 46802dd into 691b7c7 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging dcf8c56 into 691b7c7 - view on LGTM.com fixed alerts:
|
No description provided.