fix($utils): observer updater fallback

koishijs · Jan 1, 2020 · 126cb03 · 126cb03
1 parent 93e6646
commit 126cb03
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/koishi-utils/src/observe.ts b/packages/koishi-utils/src/observe.ts
@@ -117,16 +117,16 @@ export function observe <T extends object, R> (target: T, ...args: [(string | nu
     }
   }
 
-  let label = '', update: UpdateFunction<T, R> = noop
+  let label = '', update: UpdateFunction<T, R>
   if (typeof args[0] === 'function') update = args.shift() as UpdateFunction<T, R>
   if (typeof args[0] === 'string') label = args[0]
 
   if (label && label in refs) {
-    refs[label].__updateCallback__ = update
+    refs[label].__updateCallback__ = update || refs[label].__updateCallback__
     return refs[label]._merge(target)
   }
 
-  Object.defineProperty(target, '__updateCallback__', { value: update, writable: true })
+  Object.defineProperty(target, '__updateCallback__', { value: update || noop, writable: true })
 
   Object.defineProperty(target, '_update', {
     value (this: Observed<T, R>) {