fix(core): remove incorrect ctx.broadcast() impl, fix #462

koishijs · Jan 17, 2022 · 11fc702 · 11fc702
1 parent ef3be19
commit 11fc702
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 15 deletions.
diff --git a/packages/koishi/src/assets.ts b/packages/koishi/src/assets.ts
@@ -17,8 +17,8 @@ export abstract class Assets extends Service {
     super(ctx, 'assets')
   }
 
-  public transform(content: string) {
-    return segment.transformAsync(content, Object.fromEntries(this.types.map((type) => {
+  public async transform(content: string) {
+    return await segment.transformAsync(content, Object.fromEntries(this.types.map((type) => {
       return [type, async (data) => segment(type, { url: await this.upload(data.url, data.file) })]
     })))
   }
@@ -62,15 +62,3 @@ export namespace Assets {
     filename: string
   }
 }
-
-const { broadcast } = Context.prototype
-Context.prototype.broadcast = async function (this: Context, ...args: any[]) {
-  const index = Array.isArray(args[0]) ? 1 : 0
-  args[index] = await segment.transformAsync(args[index], Object.fromEntries(Assets.types.map((type) => {
-    return [type, async (data) => {
-      const buffer = await this.http.get<ArrayBuffer>(data.url, { responseType: 'arraybuffer' })
-      return segment(type, { url: 'base64://' + Buffer.from(buffer).toString('base64') })
-    }]
-  })))
-  return broadcast.apply(this, args)
-}
diff --git a/plugins/common/broadcast/tests/index.spec.ts b/plugins/common/broadcast/tests/index.spec.ts
@@ -26,7 +26,7 @@ before(async () => {
 
 describe('@koishijs/plugin-broadcast', () => {
   it('basic support', async () => {
-    const send = jest.fn<any, any[]>()
+    const send = jest.fn<Promise<string[]>, [string, string, string?]>(async () => [])
     app.bots.forEach(bot => bot.sendMessage = send)
 
     await client.shouldReply('broadcast', '请输入要发送的文本。')