fix(assets): do not upload assets from same origin (#508)

koishijs · Feb 11, 2022 · 0713f3b · 0713f3b
1 parent 994f1bb
commit 0713f3b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/plugins/assets/local/src/index.ts b/plugins/assets/local/src/index.ts
@@ -77,6 +77,7 @@ class LocalAssets extends Assets {
   }
 
   async upload(url: string, file: string) {
+    if (url.startsWith(this.config.selfUrl)) return url
     await this._promise
     const { selfUrl, path, root } = this.config
     const { buffer, filename } = await this.analyze(url, file)

diff --git a/plugins/assets/remote/src/index.ts b/plugins/assets/remote/src/index.ts
@@ -20,6 +20,7 @@ class RemoteAssets extends Assets {
   stop() {}
 
   async upload(url: string, file: string) {
+    if (url.startsWith(this.config.endpoint)) return url
     const { secret } = this.config
     const params = { url, file } as any
     if (secret) {

diff --git a/plugins/assets/s3/src/index.ts b/plugins/assets/s3/src/index.ts
@@ -36,6 +36,9 @@ class S3Assets extends Assets {
   }
 
   async upload(url: string, file: string) {
+    if (url.startsWith(this.config.publicUrl)) {
+      return url
+    }
     const { buffer, filename } = await this.analyze(url, file)
     const s3Key = `${this.config.pathPrefix}${filename}`
     const finalUrl = `${this.config.publicUrl}${filename}`