Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indeterminant linear system #92

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Fix indeterminant linear system #92

merged 4 commits into from
Oct 22, 2024

Conversation

koide3
Copy link
Owner

@koide3 koide3 commented Oct 8, 2024

  • Fix the graph when an indeterminant linear system is detected by inserting a damping factor and resetting the smoother.
  • Add a few optimization tools to the standard viewer.

@changh95
Copy link

Just tested this code - it works nicely.

I tested this code on a rosbag with some corruption when global_mapping_gpu is on. The indeterminant linear system exception arised due to corruption in dataset. Prior to this code change, the system crashed soon after. But with this code change, the isam2 resets and lets the system keep going. Despite a number of times this exception appeared, GLIM managed to terminate safely.

image

image

@koide3 koide3 merged commit 768aa50 into master Oct 22, 2024
8 checks passed
@koide3 koide3 deleted the indeterminant branch October 22, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants