Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced print with logger #1137

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

shirayu
Copy link
Contributor

@shirayu shirayu commented Feb 24, 2024

Replaced some print() calls in mainly generation scripts.

Related to #905 and #1104. (Thanks to merge these to main on v0.8.4 ! 😄 )

@kohya-ss
Copy link
Owner

Thank you again for this! I was going to fix it before I committed, but I forgot😅

@kohya-ss kohya-ss merged commit e0acb10 into kohya-ss:main Feb 25, 2024
1 check passed
kohya-ss added a commit that referenced this pull request Feb 25, 2024
@kohya-ss
Copy link
Owner

I noticed that device_utils.py is also updated. I think it might be better to use print in the script, because I cannot test IPEX and don't like to cause any defects for it. I appreciate your understanding.

wkpark pushed a commit to wkpark/sd-scripts that referenced this pull request Feb 27, 2024
Let Tensorboard works in docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants