wait for reading logs to complete before calling cmd.Wait #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangyifei <zhangyifei@koderover.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangyifei zhangyifei@koderover.com
What this PR does / Why we need it:
Problem Summary: When reading data from cmd's stdout/stderr, we need to make sure to wait for the data in stdout/stderr to be read before executing
cmd.Wait, otherwisecmd.Waitwill close the pipe, causing theread |0: file already closedexception message when reading data .See also: hashicorp/go-plugin#116
What is changed and how it works?
What's Changed: Wait before reading all data of stdout/stderr.
Check List