feat: add support for laravel 7 and 8 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axmad386
reviewed
Jun 13, 2022
There was a problem hiding this comment.
Awesome work @lakuapik. I want to discuss something
- I think
php-cs-fixerdidn't work properly. Check my comments. - how about laravel 5 and 6? it is possible to support them?
- Should we include documentation how to customize response structure? I think we need to mention
toResponsemethod part
|
@axmad386 i run ❯ date; git branch --show-current; composer test
Mon Jun 13 10:58:00 AM WIB 2022
support-laravel-7-and-8
> php-cs-fixer fix --allow-risky=yes
Loaded config default from "/media/d/data/work/labs/laravel-api-response/.php-cs-fixer.php".
Using cache file ".php-cs-fixer.cache".
Fixed all files in 0.006 seconds, 16.000 MB memory used
> pest --stop-on-failure
PASS Tests\ApiExceptionTest
✓ it can handle ApiException
✓ it returns HTTP_BAD_REQUEST for ApiException by default
✓ it can handle ApiValidationException
✓ it can access route with validated parameters
PASS Tests\ApiResponseTest
✓ it returns correct response header
✓ it returns correct json structure for success api response
✓ it returns correct json structure for error api response
✓ it fails when the argument $data is not valid
✓ it fails when the argument $errors is not valid
Tests: 9 passed
Time: 0.41sOff course we could also support laravel 5 and 6, but we need to ditch pestphp and move to phpunit. pest require minimum version of php 7.3. which is doable for laravel 7. for laravel 5 and 6, it can run below 7.3. |
Oh I see. Then it's better to exclude laravel 5 and 6 for now. |
axmad386
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR not just adding support for laravel 7 and 8, but also refactoring the core and improve documentation.
@axmad386 please kindly review and discuss features here.