Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable ssr on /privacy-policy #9154

Merged
merged 22 commits into from
Jan 27, 2024
Merged

feat: enable ssr on /privacy-policy #9154

merged 22 commits into from
Jan 27, 2024

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

@preschian
feat: test SSR mode
9d3868e
@preschian
Add ClientOnly component to default layout
d510742
@preschian
Add transpile option to build configuration
0591e37
@preschian
feat: add client-side process checks for localStorage and window objects
6bbb96d 
refactor: rename plugin files to indicate client-side usage
feat: add new posts to posts.json
fix: adjust localStorage usage in identity store
fix: adjust window object usage in chain and ipfs config
fix: adjust extension usage for client-side process
@preschian
feat(nuxt.config.ts, package.json, pnpm-lock.yaml): add 'graphql-ws' …
23d2910 
…and '@polkadot/x-global' to transpile list and update '@polkadot/x-global' version to 12.6.2
@preschian
fix(package.json): add max-old-space-size option to NODE_OPTIONS in g…
ed8f3e3 
…enerate script
@preschian
Merge branch 'main' of github.com:preschian/nft-gallery into feat/tes…
38b400f 
…t-ssr
@preschian
Comment out PWA and Sentry configurations
8e3cc75
@preschian
Update dependencies in nuxt.config.ts and package.json
799522e
@preschian
Enable sitemap plugin in nuxt.config.ts
6dc1ba7
@preschian
style: refactor computed functions to improve readability in multiple…
df90883 
… vue components

fix(package.json): downgrade eslint-plugin-unicorn, eslint-plugin-vue, glob, husky, jsdom, lint-staged versions
chore(package.json): remove unused @types/jest and @polkadot/x-global dependencies
@preschian
feat(nuxt.config.ts): enable pwa and vite-pwa/nuxt modules
43c6ef7
@preschian
chore(nuxt.config.ts): comment out pwa related imports and usage
4b80bf0
@preschian
revert
ca1d957
@preschian
Update dependencies in package.json
09cbf02
@preschian
chore(package.json): update date-fns package from version 2.30.0 to 3…
668cc2e 
….3.1
@preschian
Update Nuxt configuration to enable Vite PWA
bae0045
@preschian
feat: add new default-ssr layout
b276776 
refactor(default.vue): remove ClientOnly wrapper from Navbar, Footer, CookieBanner, and Buy components
feat(privacy-policy.vue): set page layout to default-ssr
@preschian
chore: update lock file
7de1ae3
@preschian
feat(ModelMedia.vue): add onMounted lifecycle hook to conditionally i…
20de323 
…mport '@google/model-viewer' on client side
@preschian
feat(NeoModal.scss): add modal-zindex variable with value 998
ffd4ddc
@preschian
feat(nuxt.config.ts): add sentryVitePlugin to vite plugins
4c2cec7 
fix(nuxt.config.ts): disable sourcemap in vite build configuration
@preschian preschian marked this pull request as ready for review January 27, 2024 04:55
@preschian preschian requested review from a team as code owners January 27, 2024 04:55
@preschian preschian requested review from daiagi and roiLeo and removed request for a team January 27, 2024 04:55
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Jan 27, 2024

AI-Generated Summary: This pull request contains multiple updates focused on handling server-side and client-side rendering, adding metadata, code optimization, refactoring, and version upgrades of dependencies.

  1. The logic for assigning a value to kodaImage and rmrk2ChainPrefixInHostname constant validation logic have been updated to ensure they only execute on the client-side.
  2. Changes in the nuxt.config.ts file include configuration modification under build and optimizeDeps, along with commenting out ssr.
  3. Client-side checks have been added before accessing the localStorage in the useLocalStorage.ts file and operations in identity.ts file.
  4. A new TypeScript configuration file tsconfig.json has been added to the server directory.
  5. In terms of styling, a new SCSS variable $modal-zindex was introduced in the NeoModal component.
  6. The 'privacy-policy.vue' file has been modified with the 'definePageMeta' method to define meta information with an 'default-ssr' layout.
  7. Changes in ModelMedia.vue encapsulate the import statement for @google/model-viewer inside an onMounted hook with a process client-side check.
  8. In the posts.json file, entries for October 2023 were removed and three new weekly roundup posts for KodaDot were added.
  9. Dependencies in package.json have been updated, and @types/jest has been removed from devDependencies.
  10. The files keyboardEvents.ts and pwa.ts in the plugins directory have been renamed to keyboardEvents.client.ts and pwa.client.ts respectively with no content change.
  11. A new file named disable-ssr.ts has been added to the server/middleware directory to handle server-side rendering for specified paths.
  12. Change in the handling of isProduction and isBeta constants in an unnamed file to prevent potential server-side rendering issues.
  13. A new Vue.js layout file default-ssr.vue has been introduced which includes several new components and dynamic links construction.
  14. In utils/extension.ts, the dependency on web3Enable from @polkadot/extension-dapp has been removed and localStorage operations are chained with a condition to check if the process is running on client-side.
  15. polkadot.ts in the plugins directory has been renamed to polkadot.client.ts with no content change.

These updates should be verified in different environments to ensure the functioning of the application after these changes, especially due to the package version updates to avoid any potential breaking changes.

@preschian preschian merged commit 9833a8f into kodadot:cf-ssr-privacy-policy Jan 27, 2024
4 checks passed
@preschian preschian deleted the test-ssr branch January 27, 2024 04:56
@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jan 27, 2024
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Jan 27, 2024

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi Awaiting requested review from daiagi daiagi was automatically assigned from kodadot/internal-dev

@roiLeo roiLeo Awaiting requested review from roiLeo roiLeo is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
large Pull request is large waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@preschian