Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add context offchain profile to wallet connection #10661

Merged
merged 8 commits into from
Jul 29, 2024
Merged

feat: Add context offchain profile to wallet connection #10661

merged 8 commits into from
Jul 29, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner July 19, 2024 13:50
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team July 19, 2024 13:50
@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ab9941c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66a17074b747db00086b39e3
😎 Deploy Preview https://deploy-preview-10661--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival vikiival requested a review from hassnian July 22, 2024 10:16
hassnian
hassnian reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add skeleton loader?

CleanShot 2024-07-22 at 17 18 43

@Jarsen136
Copy link
Contributor Author

can we add skeleton loader?

Yes, updated

@Jarsen136 Jarsen136 requested a review from hassnian July 22, 2024 16:55
hassnian
hassnian reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have the skeleton match the shape of the actual content, leaving the visual ok to @exezbcz

CleanShot 2024-07-23 at 11 01 39

components/common/ConnectWallet/WalletMenuItem.vue Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

reviewdog is failing

Screenshot 2024-07-23 at 10 33 12

@Jarsen136
Copy link
Contributor Author

reviewdog is failing

It's not related to this PR : )

@vikiival vikiival mentioned this pull request Jul 23, 2024
Closed
@Jarsen136
Copy link
Contributor Author

I'd rather have the skeleton match the shape of the actual content,

image
I changed the shape of the skeleton a bit.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 24, 2024

Code Climate has analyzed commit ab9941c and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vikiival
vikiival reviewed Jul 25, 2024
View reviewed changes
components/common/ConnectWallet/WalletMenuItem.vue
@@ -121,12 +144,25 @@ const emitAccountChange = (account): void => {

const ss58Format = computed(() => chainProperties.value?.ss58Format)

const walletAccountsWithProfile = computed(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break on evm

Copy link
Contributor Author

@Jarsen136 Jarsen136 Jul 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break on evm

could you expand more?

I tested connection with evm and it works well. It would not go with these codes with evm.

@vikiival
Copy link
Member

@Jarsen136 the test is still failing

@Jarsen136
Copy link
Contributor Author

@Jarsen136 the test is still failing

It got fixed here #10618 (comment)

@exezbcz
Copy link
Member

exezbcz commented Jul 27, 2024

works for me, thank you!

@hassnian hassnian added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ labels Jul 27, 2024
@vikiival vikiival merged commit 668123d into kodadot:main Jul 29, 2024
19 of 20 checks passed
This was referenced Aug 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival left review comments

@hassnian hassnian hassnian approved these changes

@preschian preschian preschian approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add context offchain profile to wallet connection
5 participants
@Jarsen136 @vikiival @exezbcz @preschian @hassnian