-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIDI file playback support #56
base: master
Are you sure you want to change the base?
Conversation
This reverts commit e90d0be
Requires ProtocolLib
Is this currently implemented in any player for testing or just API additions for future use? Edit: Assuming not yet, but if @koca2000 can merge the PR (if it's ready), MusicBox plugin would be one of the first to implement testing support once merged. |
It is currently implemented and works just fine in my testings. |
I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again. |
I got a modified JukeBox plugin here. |
Hi! This is just one of the possible variants of implementation. The final change won't break other plugins. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Closes #24