feat(attachments): add xform and user fields to Attachment model TASK-927 #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5571) ### 🗒️ Checklist 1. [X] run linter locally 2. [X] update all related docs (API, README, inline, etc.), if any 3. [X] draft PR with a title `<type>(<scope>)<!>: <title> TASK-1234` 4. [X] tag PR: at least `frontend` or `backend` unless it's global 5. [X] fill in the template below and delete template comments 6. [X] review thyself: read the diff and repro the preview as written 7. [X] open PR & confirm that CI passes 8. [X] request reviewers, if needed 9. [ ] delete this section before merging ### 💭 Notes Error from #5568. The Leaflet library needs to have the L object imported before other leaflet imports. ### 👀 Preview steps 1. ℹ️ have an account and a project 2. Navigate to the Project Summary page 4. 🔴 [on main] notice that if you click on "Data" or "Settings", an error message is shown 5. 🟢 [on PR] notice that you can click on and view the "Data" and "Settings" pages
RuthShryock
requested review from
jnm,
noliveleger and
magicznyleszek
as code owners
RuthShryock
changed the title
noliveleger
requested changes
Mar 11, 2025
Comment on lines
21
to
42
| migrations.AddField( | ||
| model_name='attachment', | ||
| name='user', | ||
| field=models.ForeignKey( | ||
| blank=True, | ||
| null=True, | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| related_name='attachments', | ||
| to=settings.AUTH_USER_MODEL, | ||
| ), | ||
| ), | ||
| migrations.AddField( | ||
| model_name='attachment', | ||
| name='xform', | ||
| field=models.ForeignKey( | ||
| blank=True, | ||
| null=True, | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| related_name='attachments', | ||
| to='logger.xform', | ||
| ), | ||
| ), |
There was a problem hiding this comment.
This migration should only contain change to the Attachment model. Remove all other changes that Django has detected (because misc differences between your environment and the production).
Please change the name of the file too to make it obvious about the changes we are applying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 Preview steps
./manage.py dbshell --database kobocat\d logger_attachment