Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore questions specified to be ignored #221

Merged
merged 5 commits into from
Jul 16, 2020
Merged

ignore questions specified to be ignored #221

merged 5 commits into from
Jul 16, 2020

Conversation

dorey
Copy link
Contributor

@dorey dorey commented Jul 15, 2020 •
edited by jnm
Loading

  • pyxform has an undocumented way to ignore questions from surveys (disabled=TRUE)
  • surveys were being deployed in KPI which had questions with this attribute
  • exports were breaking because formpack was looking for choice lists that didn't exist because the questions were "commented out"

fixes #219

@coveralls
Copy link

coveralls commented Jul 15, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 83.986% when pulling add0100 on issue-219 into 8628d7e on master.

@jnm jnm self-assigned this Jul 15, 2020
jnm
jnm requested changes Jul 15, 2020
View reviewed changes
src/formpack/version.py Outdated Show resolved Hide resolved
tests/test_formpack_internals.py Outdated Show resolved Hide resolved
dorey added 2 commits July 15, 2020 15:19
@dorey
* changed behavior to handle groups
1234c84 
* tests behavior works in the same way that pyxform handles the 
"disabled" column ("begin_group" + "end_group" need to be disabled)
@dorey
expanded test of disabled=True in begin/end groups
af00ff2
jnm
jnm requested changes Jul 15, 2020
View reviewed changes
tests/test_formpack_internals.py Outdated Show resolved Hide resolved
tests/test_formpack_internals.py Outdated Show resolved Hide resolved
@dorey
minor tweaks to tests
add0100 
readability += 1
pythonic += 1
robust_assertions += 1
@jnm jnm merged commit d8d7a64 into master Jul 16, 2020
@jnm jnm deleted the issue-219 branch July 16, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm requested changes

Assignees

@jnm jnm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore questions with disabled=True
3 participants
@dorey @coveralls @jnm