Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(combobox) prevent combobox opening for input when triggerMode set to 'manual' (#462) #465

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

caymaynard
Copy link
Contributor

Updates the combobox component to prevent opening the menu if the triggerMode has been set to manual, and the trigger source is not manual.

Other triggerModes are unaffected.

closes #462

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for kobalte ready!

Name Link
🔨 Latest commit 7512924
🔍 Latest deploy log https://app.netlify.com/sites/kobalte/deploys/66c268876c3ed00008dcedfb
😎 Deploy Preview https://deploy-preview-465--kobalte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jer3m01 jer3m01 self-assigned this Aug 18, 2024
@jer3m01 jer3m01 merged commit ea7e7f9 into kobaltedev:main Aug 21, 2024
6 of 7 checks passed
@jer3m01
Copy link
Member

jer3m01 commented Aug 21, 2024

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Combobox] setting triggerMode="manual" still opens combobox on input
2 participants