Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Toggle Group component #378

Merged
merged 6 commits into from
Mar 29, 2024
Merged

feat: Toggle Group component #378

merged 6 commits into from
Mar 29, 2024

Conversation

hngngn
Copy link
Contributor

@hngngn hngngn commented Mar 29, 2024 •
edited
Loading

Implement #314

@netlify Netlify
Copy link

netlify bot commented Mar 29, 2024 •
edited
Loading

✅ Deploy Preview for kobalte ready!

Name Link
🔨 Latest commit 610cb96
🔍 Latest deploy log https://app.netlify.com/sites/kobalte/deploys/66070877b172b50008f34a96
😎 Deploy Preview https://deploy-preview-378--kobalte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hngngn hngngn force-pushed the feat/toggle-group branch from 43622c7 to 38775e2 Compare March 29, 2024 14:05
jer3m01
jer3m01 requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@jer3m01 jer3m01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only missing formatting to pass CI (pnpm format & pnpm lint).

@hngngn hngngn requested a review from jer3m01 March 29, 2024 18:44
jer3m01
jer3m01 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@jer3m01 jer3m01 merged commit d7b53ec into kobaltedev:main Mar 29, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Merged
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jer3m01 jer3m01 jer3m01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hngngn @jer3m01