Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build workflow dependencies #2972

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

s1204IT
Copy link
Contributor

@s1204IT s1204IT commented Apr 25, 2024

No description provided.

@koalaman koalaman merged commit 15f132e into koalaman:master Aug 20, 2024
@koalaman
Copy link
Owner

Thanks! There was an issue with the artifact uploader, where it error'd out with "an artifact with this name already exists on the workflow run" which I fixed in c7611df. I'm just documenting it here for anyone else googling the message.

The v3 uploader in the build matrix used

       - name: Upload artifact
         uses: actions/upload-artifact@v3
         with:
           name: bin
           path: bin/

which failed with uses: actions/upload-artifact@v4 because name: bin was used for every configuration and v4 requires it to be unique.

I updated it to name: ${{matrix.build}}.bin so that each configuration would have a distinct name, fixing the issue.

The complete error message was:

Run actions/upload-artifact@v4
  with:
    name: bin
    path: bin/
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
##[debug]followSymbolicLinks 'true'
##[debug]implicitDescendants 'true'
##[debug]omitBrokenSymbolicLinks 'true'
##[debug]followSymbolicLinks 'true'
##[debug]implicitDescendants 'true'
##[debug]matchDirectories 'true'
##[debug]omitBrokenSymbolicLinks 'true'
##[debug]Search path '/home/runner/work/shellcheck/shellcheck/bin'
##[debug]Removing /home/runner/work/shellcheck/shellcheck/bin from rawSearchResults because it is a directory
##[debug]Removing /home/runner/work/shellcheck/shellcheck/bin/linux.aarch64 from rawSearchResults because it is a directory
##[debug]File:/home/runner/work/shellcheck/shellcheck/bin/linux.aarch64/shellcheck was found using the provided searchPath
With the provided path, there will be 1 file uploaded
##[debug]Root artifact directory is /home/runner/work/shellcheck/shellcheck/bin
Artifact name is valid!
Root directory input is valid!
##[debug]Workflow Run Backend ID: 46f06305-bae5-44fa-90ab-c018e5dc48fc
##[debug]Workflow Job Run Backend ID: c5305072-[11](https://github.com/koalaman/shellcheck/actions/runs/10463283731/job/28976071244#step:5:11)f8-55ad-a09f-15e5d746a37c
##[debug][Request] CreateArtifact https://results-receiver.actions.githubusercontent.com/twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact
##[debug][Response] - 409
##[debug]Headers: {
##[debug]  "content-length": "95",
##[debug]  "content-type": "application/json",
##[debug]  "date": "Tue, 20 Aug 2024 01:32:55 GMT",
##[debug]  "x-github-backend": "Kubernetes",
##[debug]  "x-github-request-id": "D081:269EF4:22[15](https://github.com/koalaman/shellcheck/actions/runs/10463283731/job/28976071244#step:5:15)E4:33DB2C:66C3F247"
##[debug]}
##[debug]Body: {
##[debug]  "code": "already_exists",
##[debug]  "msg": "an artifact with this name already exists on the workflow run"
##[debug]}
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Upload artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants