Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coverage and tests #58

Merged
merged 9 commits into from
Feb 17, 2020

Conversation

JacobMGEvans
Copy link
Contributor

  • Test Coverage was not checked with local tooling, added Istanbul (nyc) for a script that could be added to check coverage when writing tests.
  • Some negative flows tested to improve coverage.
  • Layer and Router modules tests added.

Resolves #57

@JacobMGEvans JacobMGEvans marked this pull request as ready for review February 17, 2020 03:50
@JacobMGEvans
Copy link
Contributor Author

Screen Shot 2020-02-16 at 9 51 35 PM

@niftylettuce niftylettuce merged commit 24d0a4f into koajs:master Feb 17, 2020
@JacobMGEvans JacobMGEvans deleted the feature/coverage-and-tests branch March 12, 2020 23:25
JacobMGEvans added a commit to JacobMGEvans/router that referenced this pull request Mar 14, 2020
* Added Istanbul for coverage with tests

* Working on Layer coverage 100%

* New test covers line 76 param if check on paramNames

* New test covers line 76 param if check on paramNames

* Test Coverage increased, 1 new test assertion failing but line is covered

* Error flow tests for URL method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write More Tests, Improve Coverage, Add Istanbul for coverage
2 participants