Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for optional route parameter #43

Merged
merged 4 commits into from
Jun 1, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions test/lib/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,44 @@ describe('Router', function () {
});
});

it('matches corresponding requests with optional route parameter', function (done) {
const app = new Koa();
const router = new Router();
app.use(router.routes());
router.get('/resources', function (ctx) {
ctx.should.have.property('params');
ctx.params.should.be.empty();
ctx.status = 204;
});
const id = '10';
const ext = '.json';
router.get('/resources/:id{.:ext}?', function (ctx) {
ctx.should.have.property('params');
ctx.params.should.have.property('id', id);
if (ctx.params.ext) ctx.params.ext.should.be.equal(ext.substring(1));
ctx.status = 204;
});
const server = http.createServer(app.callback());
request(server)
.get('/resources')
.expect(204)
.end(function (err, res) {
if (err) return done(err);
request(server)
.get('/resources/' + id)
.expect(204)
.end(function (err, res) {
if (err) return done(err);
request(server)
.get('/resources/' + id + ext)
.expect(204)
.end(function (err, res) {
done(err);
});
});
});
});

it('executes route middleware using `app.context`', function (done) {
const app = new Koa();
const router = new Router();
Expand Down