router.url behaves unexpectedly for a named route that has no path …

…parameters. (#37) * demonstrate issue * fix
koajs · Jul 5, 2020 · 1b06bd1 · 1b06bd1
1 parent ae0745c
commit 1b06bd1
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/lib/layer.js b/lib/layer.js
@@ -133,7 +133,7 @@ Layer.prototype.url = function (params, options) {
     }
   } else if (tokens.some(token => token.name)) {
     replace = params;
-  } else {
+  } else if (!options) {
     options = params;
   }
 

diff --git a/test/lib/router.js b/test/lib/router.js
@@ -1365,8 +1365,32 @@ describe('Router', function () {
     })
 
     it('generates URL for given route name without params and query params', function(done) {
-        const app = new Koa();
-        const router = new Router();
+        var router = new Router();
+        router.get('books', '/books', function (ctx) {
+          ctx.status = 204;
+        });
+        var url = router.url('books');
+        url.should.equal('/books');
+        var url = router.url('books');
+        url.should.equal('/books', {});
+        var url = router.url('books');
+        url.should.equal('/books', {}, {});
+        var url = router.url('books',
+          {},
+          { query: { page: 3, limit: 10 } }
+        );
+        url.should.equal('/books?page=3&limit=10');
+        var url = router.url('books',
+          {},
+          { query: 'page=3&limit=10' }
+        );
+        url.should.equal('/books?page=3&limit=10');
+        done();
+    })
+
+
+    it('generates URL for given route name without params and query params', function(done) {
+        var router = new Router();
         router.get('category', '/category', function (ctx) {
           ctx.status = 204;
         });