accept options in the Application constructor #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1372 +/- ##
======================================
Coverage 100% 100%
======================================
Files 4 4
Lines 377 378 +1
======================================
+ Hits 377 378 +1
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Aug 15, 2019
|
Update the document https://github.com/koajs/koa/blob/master/docs/api/index.md#application ? |
fl0w
suggested changes
Aug 15, 2019
lib/application.js
Outdated
| * @param {object} [options] Application options | ||
| * @param {string} [options.env='development'] Environment | ||
| * @param {string[]} [options.keys] Signed cookie keys | ||
| * @param {string} [options.proxy] Trust proxy headers |
There was a problem hiding this comment.
options.proxy is not a string, but a boolean
| * @param {string} [options.proxy] Trust proxy headers | ||
| * @param {number} [options.subdomainOffset] Subdomain offset | ||
| * | ||
| */ |
There was a problem hiding this comment.
For consistency, add a newline between constructor-method and */.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept an options object on the application constructor to configure app.env, app.proxy, app.keys, and app.subdomainOffset.
#1370