Skip to content

Commit

Permalink
fix linter issues
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinpeno committed Oct 20, 2024
1 parent bba5d05 commit ad03d65
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 39 deletions.
32 changes: 32 additions & 0 deletions __tests__/response/back.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
'use strict'

const assert = require('assert')
const context = require('../../test-helpers/context')

describe('ctx.back([alt])', () => {
it('should redirect to Referrer', () => {
const ctx = context()
ctx.req.headers.referrer = '/login'
ctx.back()
assert.equal(ctx.response.header.location, '/login')
})

it('should redirect to Referer', () => {
const ctx = context()
ctx.req.headers.referer = '/login'
ctx.back()
assert.equal(ctx.response.header.location, '/login')
})

it('should default to alt', () => {
const ctx = context()
ctx.back('/index.html')
assert.equal(ctx.response.header.location, '/index.html')
})

it('should default redirect to /', () => {
const ctx = context()
ctx.back()
assert.equal(ctx.response.header.location, '/')
})
})
12 changes: 6 additions & 6 deletions lib/response.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const only = require('./only.js')
const util = require('util')
const encodeUrl = require('encodeurl')
const Stream = require('stream')
const deprecate = require('depd')('koa');
const deprecate = require('depd')('koa')

/**
* Prototype.
Expand Down Expand Up @@ -296,8 +296,8 @@ module.exports = {
// location
if (url === 'back') {
deprecate('Special-cased string "back" through redirect will be removed in v3, ' +
'consider migrating usage to ctx.back() instead.');
url = this.ctx.get('Referrer') || alt || '/';
'consider migrating usage to ctx.back() instead.')
url = this.ctx.get('Referrer') || alt || '/'
}
if (/^https?:\/\//i.test(url)) {
// formatting url again avoid security escapes
Expand Down Expand Up @@ -334,9 +334,9 @@ module.exports = {
* @api public
*/

back(alt) {
const url = this.ctx.get('Referrer') || alt || '/';
this.redirect(url);
back (alt) {
const url = this.ctx.get('Referrer') || alt || '/'
this.redirect(url)
},

/**
Expand Down
33 changes: 0 additions & 33 deletions test/response/back.js

This file was deleted.

0 comments on commit ad03d65

Please sign in to comment.