Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base image information to SPDX SBOMs #744

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

mattmoor
Copy link
Collaborator

@mattmoor mattmoor commented Jul 3, 2022

WIP until #743 lands.

I'm going to split off the annotation change as well, but including here so that things work.

@codecov-commenter
Copy link

Codecov Report

Merging #744 (50f5c0f) into main (d17aca8) will decrease coverage by 0.18%.
The diff coverage is 31.34%.

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   51.38%   51.19%   -0.19%     
==========================================
  Files          44       44              
  Lines        3295     3313      +18     
==========================================
+ Hits         1693     1696       +3     
- Misses       1390     1404      +14     
- Partials      212      213       +1     
Impacted Files Coverage Δ
pkg/commands/deps.go 13.59% <0.00%> (+0.50%) ⬆️
pkg/build/gobuild.go 60.10% <32.30%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17aca8...50f5c0f. Read the comment docs.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Jul 3, 2022

I broke off the annotation change here: #745

@mattmoor mattmoor force-pushed the base-image-sbom-reference branch 4 times, most recently from fe6e402 to 58cf87b Compare July 5, 2022 18:58
@mattmoor mattmoor force-pushed the base-image-sbom-reference branch from 58cf87b to 36a448a Compare July 5, 2022 19:49
@mattmoor mattmoor changed the title [WIP] Add base image information to SPDX SBOMs Add base image information to SPDX SBOMs Jul 5, 2022
@mattmoor mattmoor requested review from imjasonh and jonjohnsonjr July 5, 2022 19:52
@mattmoor
Copy link
Collaborator Author

mattmoor commented Jul 5, 2022

cc @puerco

@mattmoor mattmoor merged commit 9139f45 into ko-build:main Jul 5, 2022
@mattmoor mattmoor deleted the base-image-sbom-reference branch July 5, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants