Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate --insecure-registry to base image #370

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #369

@codecov-commenter
Copy link

Codecov Report

Merging #370 (96b5e2d) into main (d6b3a3c) will decrease coverage by 0.16%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   43.60%   43.43%   -0.17%     
==========================================
  Files          33       33              
  Lines        1564     1570       +6     
==========================================
  Hits          682      682              
- Misses        755      760       +5     
- Partials      127      128       +1     
Impacted Files Coverage Δ
pkg/commands/apply.go 0.00% <0.00%> (ø)
pkg/commands/create.go 0.00% <0.00%> (ø)
pkg/commands/publish.go 0.00% <0.00%> (ø)
pkg/commands/resolve.go 0.00% <0.00%> (ø)
pkg/commands/run.go 0.00% <0.00%> (ø)
pkg/commands/config.go 55.12% <50.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b3a3c...96b5e2d. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 23ecf47 into ko-build:main Jun 1, 2021
@jonjohnsonjr jonjohnsonjr deleted the insecure branch June 1, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ko uses https with local registry
3 participants