Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for 22 #42

Merged
merged 7 commits into from
Jul 7, 2021
Merged

Tests for 22 #42

merged 7 commits into from
Jul 7, 2021

Conversation

Urhengulas
Copy link
Member

@Urhengulas Urhengulas commented Jun 14, 2021 •
edited
Loading

Also partially depends on #40 and fixes #26, by implementing tests for #22.

@Urhengulas Urhengulas force-pushed the tests-for-22 branch 2 times, most recently from 90051c3 to 49c1855 Compare June 16, 2021 14:21
@Urhengulas Urhengulas marked this pull request as ready for review June 30, 2021 12:54
@Urhengulas Urhengulas requested a review from japaric June 30, 2021 12:54
japaric
japaric requested changes Jun 30, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some issues in the implementation and I'm not sure the new test is indeed testing what it's meant to do so I'd like my inline comments to be addressed before a take a closer look at the actual assertions.

tests/verify.rs Show resolved Hide resolved
test-flip-link-app/build.rs Outdated Show resolved Hide resolved
tests/verify.rs Show resolved Hide resolved
@Urhengulas
Copy link
Member Author

@japaric I've addressed your comments, so I think it is good for a review again 😄

@Urhengulas Urhengulas requested a review from japaric July 7, 2021 13:16
japaric
japaric approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than my request to use a Cargo feature named "lm3s6965" instead of "default", this looks good to me! feel free to send it to bors with or without my request fulfilled

test-flip-link-app/examples/crash.rs Outdated Show resolved Hide resolved
test-flip-link-app/Cargo.toml Show resolved Hide resolved
@Urhengulas
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 7, 2021

Build succeeded:

@bors bors bot merged commit a9df0b9 into main Jul 7, 2021
@bors bors bot deleted the tests-for-22 branch July 7, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees

@japaric japaric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: add regression test for #22
2 participants
@Urhengulas @japaric