Add support for section length arithmetic using + sign as used in stm32f7xx-hal crate. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this seems fine to me, but it doesn't allow multiple RAM regions, right? Just addition in the length specification? |
yeah, the title is not accurate: it doesn't enable multiple RAM regions; it enables arithmetic (addition) in the LENGTH info of RAM regions |
|
PR #15 has landed. restarting CI still fails though (I re-started the CI job). I think rebasing (or maybe just pushing a new commit?) may be needed. @matoushybl could you rebase this PR against the tip of the "main" branch? |
… the stm32f7xx-hal crate.
matoushybl
changed the title
|
Thank you for the fast review, CI seems to be fixed now. I have renamed the PR for future reference so that the name is not misleading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for defining the RAM region's length as
10K + 10M. This type of notation is used in the stm32f7xx-hal crate and flip-link failed with the messageMEMORY.RAM found after scanning linker scriptswhich was also fixed to add the missingnot.