Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run snapshot & backcompat tests in dev mode #600

Merged
merged 1 commit into from
Oct 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions firmware/qemu/src/bin/alloc.release.out

This file was deleted.

3 changes: 0 additions & 3 deletions firmware/qemu/src/bin/assert-eq.release.out

This file was deleted.

2 changes: 0 additions & 2 deletions firmware/qemu/src/bin/assert-ne.release.out

This file was deleted.

1 change: 0 additions & 1 deletion firmware/qemu/src/bin/assert.release.out

This file was deleted.

12 changes: 0 additions & 12 deletions firmware/qemu/src/bin/bitflags.release.out

This file was deleted.

1 change: 0 additions & 1 deletion firmware/qemu/src/bin/dbg.release.out

This file was deleted.

8 changes: 0 additions & 8 deletions firmware/qemu/src/bin/defmt-test.release.out

This file was deleted.

59 changes: 0 additions & 59 deletions firmware/qemu/src/bin/hints.release.out

This file was deleted.

10 changes: 0 additions & 10 deletions firmware/qemu/src/bin/hints_inner.release.out

This file was deleted.

145 changes: 0 additions & 145 deletions firmware/qemu/src/bin/log.release.out

This file was deleted.

1 change: 0 additions & 1 deletion firmware/qemu/src/bin/panic.release.out

This file was deleted.

2 changes: 0 additions & 2 deletions firmware/qemu/src/bin/timestamp.release.out

This file was deleted.

3 changes: 0 additions & 3 deletions firmware/qemu/src/bin/unwrap.release.out

This file was deleted.

26 changes: 7 additions & 19 deletions xtask/src/backcompat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use anyhow::anyhow;
use colored::Colorize as _;
use tempfile::TempDir;

use crate::{utils, ALL_ERRORS, ALL_SNAPSHOT_TESTS, SNAPSHOT_TESTS_DIRECTORY};
use crate::{ALL_ERRORS, ALL_SNAPSHOT_TESTS, SNAPSHOT_TESTS_DIRECTORY};

// use this format: PR <number> - <what feature / change broke compatibility>
// PR #569 - defmt::println!
Expand All @@ -34,13 +34,8 @@ pub fn test() {
}
};

for release_mode in [false, true] {
for snapshot_test in ALL_SNAPSHOT_TESTS {
super::do_test(
|| qemu_run.run_snapshot(snapshot_test, release_mode),
"backcompat",
);
}
for snapshot_test in ALL_SNAPSHOT_TESTS {
super::do_test(|| qemu_run.run_snapshot(snapshot_test), "backcompat");
}
}

Expand All @@ -63,22 +58,15 @@ impl QemuRun {
})
}

fn run_snapshot(&self, name: &str, release_mode: bool) -> anyhow::Result<()> {
let formatted_test_name = utils::formatted_test_name(name, release_mode);
println!("{}", formatted_test_name.bold());

let args = if release_mode {
["-q", "rrb", name]
} else {
["-q", "rb", name]
};
fn run_snapshot(&self, name: &str) -> anyhow::Result<()> {
println!("{}", name.bold());

run_silently(
Command::new("cargo")
.args(args)
.args(["-q", "rb", name])
.current_dir(SNAPSHOT_TESTS_DIRECTORY)
.env(RUNNER_ENV_VAR, self.path()),
|| anyhow!("{}", formatted_test_name),
|| anyhow!("{}", name.to_string()),
)?;

Ok(())
Expand Down
Loading