Refactor user-guide of book
#529
Merged
+294
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urhengulas
force-pushed
the
refactor-book
branch
from
7f1c448 to
3a1b78a
Compare
* `setup`: Deduplicate setup * `setup-app`: name `cargo.toml`; add `defmt-itm` * `macros`: Language * `primitives`: Table-ize and drop `u24` (got dropped in (#521)) * `str`: Add links to doc-rs * ...
Urhengulas
force-pushed
the
refactor-book
branch
from
4493ec5 to
37d05b9
Compare
japaric
approved these changes
Jul 14, 2021
| When the alternate form is used for hex and binary, the `0x`/`0b` length is subtracted from the | ||
| leading zeros. This matches [`core::fmt` behavior](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=b11809759f975e266251f7968e542756). No further | ||
| customization is supported (at the moment). | ||
| ## Alternate printing |
There was a problem hiding this comment.
could you include in this section that {}, "hello" is formatted as hello but that {:#}, "hello" is formatted as "hello" and note that this matches core::fmt behavior
There was a problem hiding this comment.
I guess you mean {:?}? I am generally unsure what the ? does anyways, since we don't have separate Debug formatting.
There was a problem hiding this comment.
I'll merge it without this being resolved and will raise the question in zulip :)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the user guide of the book to the dirbaio PRs and is doing quite some refactoring on the side.
Preview: https://deploy-preview-529--admiring-dubinsky-56dff5.netlify.app